pkg/terminal: add exit -d to detach without killing the process#4387
Open
larrasket wants to merge 1 commit into
Open
pkg/terminal: add exit -d to detach without killing the process#4387larrasket wants to merge 1 commit into
larrasket wants to merge 1 commit into
Conversation
aarzilli
reviewed
Jul 5, 2026
aarzilli
left a comment
aarzilli
left a comment
Member
There was a problem hiding this comment.
What's the use case for this? I think something like this came up before and it's actually fewer keystrokes to answer the prompt.
aarzilli
reviewed
Jul 5, 2026
| @@ -0,0 +1,58 @@ | |||
| package terminal | |||
Member
There was a problem hiding this comment.
This can just go in terminal_test.go
aarzilli
reviewed
Jul 5, 2026
| kill := true | ||
| if t.client.AttachedToExistingProcess() { | ||
| switch { | ||
| case t.detachNoKill: |
Member
There was a problem hiding this comment.
This branch should be after the AttachedToExistingProcess check.
Contributor
Author
|
@aarzilli #2324 leaving an attached process running without answering the prompt every time is the use case. interactively yes it just saves answering n. The concrete gain is non-interactive use (for example yesno goes through |
When attached to a running process, exit prompts whether to kill it. For scripted or repetitive sessions there was no way to answer that prompt in advance. Add an exit -d flag that detaches from the target, leaving it running, without prompting. exitCommand records the intent on the terminal and handleExit skips the kill prompt and detaches with kill=false. Fixes go-delve#2324
larrasket
force-pushed
the
exit-detach-without-kill
branch
from
04fd239 to
e64c30c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an exit -d flag that detaches from the target.
exitCommandrecords the intent on the terminal andhandleExitskips the kill prompt and detaches withkill=false.Fixes #2324
pkg/terminal/exit_test.go was generated by Claude Sonnet 5